[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

2020-05-11 Thread Zola Bridges via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG379e68a76309: [clang][SLH] Add __has_feature(speculative_load_hardening) (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79733/new/ https

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

2020-05-11 Thread Zola Bridges via Phabricator via cfe-commits
zbrid updated this revision to Diff 263247. zbrid added a comment. Change langopt type + SpeculativeLoadHardeningEnabled -> SpeculativeLoadHardening This is to match the CodeGenOpt for SLH that already exists and to address mattdr's feedback. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

2020-05-11 Thread Matthew Riley via Phabricator via cfe-commits
mattdr added subscribers: rsmith, mattdr. mattdr added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:369 +BENIGN_LANGOPT(SpeculativeLoadHardeningEnabled, 1, 0, + "Speculative load hardening enabled") I've read the descript

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

2020-05-11 Thread Zola Bridges via Phabricator via cfe-commits
zbrid marked an inline comment as done. zbrid added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5357 - if (Args.hasFlag(options::OPT_mspeculative_load_hardening, options::OPT_mno_speculative_load_hardening, - false)) + if (Args.hasFla

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

2020-05-11 Thread Zola Bridges via Phabricator via cfe-commits
zbrid marked an inline comment as done. zbrid added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5357 - if (Args.hasFlag(options::OPT_mspeculative_load_hardening, options::OPT_mno_speculative_load_hardening, - false)) + if (Args.hasFla

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

2020-05-11 Thread Zola Bridges via Phabricator via cfe-commits
zbrid created this revision. zbrid added reviewers: craig.topper, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid marked an inline comment as done. zbrid added inline comments. zbrid marked an inline comment as done. Comment at: clang/lib/Dr