[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6fcf5ca033a: [clang][BFloat] add NEON emitter for bfloat (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 268616. stuij marked 7 inline comments as done. stuij added a comment. addressed remaining nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/cla

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

SjoerdMeijer added a comment. No objections. Some nits inlined, which you can ignore if you think they are not correct. Comment at: clang/include/clang/Basic/arm_neon_incl.td:218 // d: double +// b: bfloat // nit: perhaps bfloat16? Comment

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM! Might be worth waiting an extra day or two before submitting to make sure the people who provided extra feedback are happy. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 266085. stuij added a comment. add bfloat header test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td clang/include/clang

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 265988. stuij added a comment. replanted arg passing test from other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2416 +" *\n" +" * Permission is hereby granted, free of charge, to any person " +"obtaining a copy\n" stuij wrote: > Sjoe

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 265524. stuij added a comment. addressed review comments, most of all changed license header on the generated bfloat file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2198 +static void emitNeonTypeDefs(const std::string& types, raw_ostream &OS) { + std::string TypedefTypes(types); stuij wrote: > fpetrogalli wrote: > > Is this related to the

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij marked 6 inline comments as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_bf16.td:1 +//===--- arm_fp16.td - ARM FP16 compiler interface ===// +// SjoerdMeijer wrote: > typo: fp16 - > bf16? > Here, and

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 264587. stuij added a comment. adhere to patch attribution conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td cl

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/arm_bf16.td:1 +//===--- arm_fp16.td - ARM FP16 compiler interface ===// +// typo: fp16 - > bf16? Here, and a few more places, or is it intentional? If so, I guess t

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli added a comment. Hi @stuij , thank you for working on this. Would it make sense to add a test that includes the header file you have created? Regards, Francesco Comment at: clang/include/clang/Basic/arm_neon_incl.td:293 + + string CartesianProductWith = ""; }