[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

2020-05-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcc9fefec4368: [clangd] Make version in PublishDiagnosticsParams optional (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D79692?vs=263084&id=263117#toc Repository: rG LLVM G

[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

2020-05-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Protocol.cpp:569 +Result["version"] = PDP.version; + // FIXME: workaround for older gcc/clang + return std::move(Result);

[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

2020-05-10 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We were serializing it no matter what, which was against the spec Repository: rG LLVM Github Monore