thakis added a comment.
This broke tests on Windows: http://45.33.8.238/win/15539/step_9.txt
Please take a look, and revert if it takes a while to investigate.
(I'll note that the presubmit bot now has a win/msvc bot that failed compile
and reported this on this review before it got merged:
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9b88a190b42a: [clangd] Add CSV export for trace metrics
(authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79678/new/
https://reviews.ll
sammccall updated this revision to Diff 263137.
sammccall added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79678/new/
https://reviews.llvm.org/D79678
Files:
clang-tools-extra/clangd/support/Trace.cpp
clang-tools-
sammccall marked 6 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/support/Trace.cpp:210
+assert(!needsQuote(Metric.Name));
+std::string QuotedLabel;
+if (needsQuote(Label))
kadircet wrote:
> do we ever e
kadircet accepted this revision.
kadircet marked 2 inline comments as done.
kadircet added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Comment at: clang-tools-extra/clangd/support/Trace.cpp:210
+assert(!needsQuote(Metric.Name));
+std::strin
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
Example:
https://docs.google.com/spreadsheets/d/1VZKGetSUTTDe9p4ooIETmdcwUod1_aE3vgD0E9x7HhI/edi
