[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

2020-05-08 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8e7bb37dfb00: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName (authored by adamcz, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

2020-05-08 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 262857. adamcz marked an inline comment as done. adamcz added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79582/new/ https://reviews.llvm.org/D79582 Files: clang-tools-ex

[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

2020-05-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks for tracking it down. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:214 +if (D->getDecl()->getDeclName().getNameKind() == +DeclarationN

[PATCH] D79582: [clangd] Fix crash in AddUsing tweak due to non-identifier DeclName

2020-05-07 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79582 Files: clang-tools-extra/c