[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG910871532101: [clangd] Fix AddUsing tweak for out-of-line functions. (authored by adamcz, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:2673 +void foo::fun() { + one::two::f^f(); +})cpp", adamcz wrote: > hokein wrote: > > IIUC, before this patch, the using was added inside the above namespace > > `foo`,

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

adamcz marked an inline comment as done. adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:2673 +void foo::fun() { + one::two::f^f(); +})cpp", hokein wrote: > IIUC, before this patch, the using was added inside the above

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:2673 +void foo::fun() { + one::two::f^f(); +})cpp", IIUC, before this patch, the using

[PATCH] D79496: [clangd] Fix AddUsing tweak for out-of-line functions.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We used getEnclosingNamespaceContext(), which calls getParent() rather than getLexicalParent(), so w