[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-25 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG61f72dd8ace7: [FPEnv] Small fixes to implementation of flt.rounds (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-25 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://reviews.llvm.org/D79322 ___

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-25 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 265990. sepavloff edited the summary of this revision. sepavloff added a comment. Updated patch - Removed support for lowering to library call at all. Now it is NFC patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-18 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) craig.topper wrote: > sepavloff wro

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-18 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 264623. sepavloff added a comment. Updated patch Default lowering of FLT_ROUNDS_ again is made by replacing the node with constant 1, which denotes rounding to nearest, ties to even. It is incorrect, but is compatible with with current behavior. Using more

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-16 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) sepavloff wrote: > lenary wrote: > > I'm interested to understand how this f

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) lenary wrote: > I'm interested to u

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-15 Thread Sam Elliott via Phabricator via cfe-commits
lenary added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) I'm interested to understand how this function is provided. Is it part of `compil

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 264184. sepavloff added a comment. Updated patch - rebased, - corrected documentation, - fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://reviews.llvm.org/D79322 Files: c

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-04 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: andrew.w.kaylor, kpn, craig.topper, RKSimon, asb, hfinkel. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, jdoerfert, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,