[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb added a comment. Here's the RFC: http://lists.llvm.org/pipermail/cfe-dev/2020-May/065385.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 ___ cfe-commit

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. In D79279#2016604 , @jfb wrote: > In D79279#2016573 , @rjmccall wrote: > > > In D79279#2016570 , @rjmccall > > wrote: > > > > > I do think this is

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb added a comment. In D79279#2016573 , @rjmccall wrote: > In D79279#2016570 , @rjmccall wrote: > > > I do think this is a somewhat debatable change in the behavior of these > > builtins, though. > > > Let me put

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. In D79279#2016570 , @rjmccall wrote: > I do think this is a somewhat debatable change in the behavior of these > builtins, though. Let me put more weight on this. You need to propose this on cfe-dev. Repository: rG LLVM Gi

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. In D79279#2016496 , @jfb wrote: > In D79279#2015983 , @rjmccall wrote: > > > Most of the complexity of this patch is introduced by the decision to > > type-check these calls with a volatil

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb added a comment. In D79279#2015983 , @rjmccall wrote: > Most of the complexity of this patch is introduced by the decision to > type-check these calls with a volatile-typed parameter, which seems like it > does nothing but cause problems. If your go

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. Most of the complexity of this patch is introduced by the decision to type-check these calls with a volatile-typed parameter, which seems like it does nothing but cause problems. If your goal is to make these functions do the right thing when given arbitrary pointer t

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb created this revision. Herald added subscribers: cfe-commits, ributzka, dexonsmith, jkorous, JDevlieghere. Herald added a project: clang. These builtins are often used (or should be used) in places where time-of-check time-of-use security issues are important (e.g. copying from untrusted buff