[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-06 Thread Richard Sandiford via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4574df52fd: [docs] Regenerate DiagnosticsReference.rst (authored by rsandifo-arm). Changed prior to commit: https://r

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-05 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm reclaimed this revision. rsandifo-arm added a comment. OK, thanks! Reclaiming and reopening the revision in that case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79236/new/ https://reviews.llvm.org/D79236 ___

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D79236#2019184 , @rsmith wrote: > In D79236#2019005 , @rjmccall wrote: > > > Okay. So it doesn't just run `ninja docs-clang-html`? That's unfortunate. > > > It didn't last time I looke

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D79236#2019005 , @rjmccall wrote: > Okay. So it doesn't just run `ninja docs-clang-html`? That's unfortunate. It didn't last time I looked into this. And http://clang.llvm.org/docs/DiagnosticsReference.html shows the "before

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D79236#2018891 , @rsmith wrote: > In D79236#2018812 , @rjmccall wrote: > > > In D79236#2018661 , @rsmith wrote: > > > > > We do generate this doc

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D79236#2018812 , @rjmccall wrote: > In D79236#2018661 , @rsmith wrote: > > > We do generate this document with tblgen already. The problem is that it's > > not automatically regenerated a

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D79236#2018661 , @rsmith wrote: > In D79236#2015982 , @rjmccall wrote: > > > There's no good reason for this file to exist; documenting the warning > > options is useful, but the file s

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D79236#2015982 , @rjmccall wrote: > There's no good reason for this file to exist; documenting the warning > options is useful, but the file should be generated as an intermediate output > of the documentation build and then ul

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D79236#2018190 , @rsandifo-arm wrote: > OK, I'll leave the file as-is in that case. I think it's preferable to commit the file in its updated state so that the public documentation is kept up to date rather than being

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm abandoned this revision. rsandifo-arm added a comment. OK, I'll leave the file as-is in that case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79236/new/ https://reviews.llvm.org/D79236

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-01 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. There's no good reason for this file to exist; documenting the warning options is useful, but the file should be generated as an intermediate output of the documentation build and then ultimately fed into Sphinx. There's even a TODO in the docs about it: > TODO: Gener

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-01 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm created this revision. rsandifo-arm added reviewers: aaron.ballman, efriedma, rjmccall. Herald added subscribers: cfe-commits, s.egerton, jfb, simoncook, aheejin. Herald added a reviewer: jdoerfert. Herald added a project: clang. rsandifo-arm added a child revision: D79244: [Sema] Put