[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

2020-05-01 Thread Nico Weber via Phabricator via cfe-commits
thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79223/new/ https://reviews.llvm.org/D79223 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

2020-05-01 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. OK as is, but please consider re-using `llvm::sys::path` to distinguish separators. Please also check that there are no regressions in the clang VFS tests. Comment at:

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

2020-05-01 Thread Nico Weber via Phabricator via cfe-commits
thakis updated this revision to Diff 261481. thakis edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79223/new/ https://reviews.llvm.org/D79223 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Lexer/case-insensitive-include-ms.c clang/test/Lexer/ca

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

2020-04-30 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The approach in D3 assumes that the '/' returned by path::begin() is the first element for absolute paths, but that's not true