[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D79210#2025547 , @MaskRay wrote: > @yaxunl The plural form `--print-targets` may make more sense to be > consistent with other plural form options (--print-search-dirs, > --print-diagnostic-categories, etc) Agree Repository

[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. @yaxunl The plural form `--print-targets` may make more sense to be consistent with other plural form options (--print-search-dirs, --print-diagnostic-categories, etc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/ne

[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D79210#2025058 , @thakis wrote: > In D79210#2025009 , @thakis wrote: > > > We've talked about this 3 years ago in https://reviews.llvm.org/D33900 and > > back then decided that this shoul

[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D79210#2025009 , @thakis wrote: > We've talked about this 3 years ago in https://reviews.llvm.org/D33900 and > back then decided that this should go behind a different flag. Has anything > changed since then? To expand a bit:

[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. We've talked about this 3 years ago in https://reviews.llvm.org/D33900 and back then decided that this should go behind a different flag. Has anything changed since then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/

[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D79210#2024555 , @hans wrote: > I think this is worth a short note in docs/ReleaseNotes.rst. https://reviews.llvm.org/D79565 Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D79210: Let clang print registered targets for --version

2020-05-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. I think this is worth a short note in docs/ReleaseNotes.rst. Also this broke Goma which we use in Chromium (https://chromium.googlesource.com/infra/goma/client/) because it's a bit too strict when parsing the output of "clang -v" -- but that's our problem and we'll fix. :

[PATCH] D79210: Let clang print registered targets for --version

2020-05-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG66041187c902: Let clang print registered targets for --version (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D79210: Let clang print registered targets for --version

2020-05-01 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yeah, it's fine. We might want to put it behind a "long information" option, but for now it's ok. Keep an eye open if someone complains please. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D79210: Let clang print registered targets for --version

2020-05-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Is it OK to commit this? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D79210: Let clang print registered targets for --version

2020-04-30 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. A sample output: clang --version clang version 11.0.0 (https://github.com/llvm/llvm-project d0a30964c78cec2e3907be8ec16cfbec69bc3f2d) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /home/yaxunl/git/llvm/assert/bin Registered Targets: aarch64

[PATCH] D79210: Let clang print registered targets for --version

2020-04-30 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. LGTM if it works? Can you post the output into the commit message so we can review that here? I guess clang -v or something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210 ___

[PATCH] D79210: Let clang print registered targets for --version

2020-04-30 Thread Artem Belevich via Phabricator via cfe-commits
tra added a reviewer: echristo. tra added a subscriber: echristo. tra added a comment. LGTM, I've been annoyed by the lack of this info in the past. I've added @echristo for the driver owner's stamp of approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.ll

[PATCH] D79210: Let clang print registered targets for --version

2020-04-30 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. We need a way to know supported targets by clang since we use clang as assembler. This patch let clang print registered targets when --version option is passed to clang. https://reviews.llvm.org/D79210 Files: clang/lib/Dr