This revision was automatically updated to reflect the committed changes.
Closed by commit rGa3a27a7aeed6: [clangd] Render code complete documentation as
plaintext/markdown. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D79157?vs=261185&id=261278#toc
Repository:
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377
+ auto SetDoc = [&](llvm::StringRef Doc) {
+if (!Doc.trim().empty()) {
+ Completion.Documentation.emplace();
--
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM thanks!
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377
+ auto SetDoc = [&](llvm::StringRef Doc) {
+if (!Doc.trim().empty()) {
+ Comp
sammccall updated this revision to Diff 261185.
sammccall marked an inline comment as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79157/new/
https://reviews.llvm.org/D79157
Files:
clang-tools-e
sammccall marked 6 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377
+ auto SetDoc = [&](llvm::StringRef Doc) {
+if (!Doc.trim().empty()) {
+ Completion.Documentation.emplace();
--
kadircet marked an inline comment as done.
kadircet added a comment.
thanks, mostly LG apart from dropping of white-space only comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:377
+ auto SetDoc = [&](llvm::StringRef Doc) {
+if (!Doc.trim().empty()) {
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Structure is parsed from the raw comment using the existing heuristics used
for hover.
Repository:
