[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGec170b7ccd5b: [clangd] Fix whitespace between chunks in markdown paragraphs. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. thanks lgtm! Comment at: clang-tools-extra/clangd/FormattedString.cpp:439 + bool AdjacentCode = + !Chunks.empty() && Chun

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:439 + bool AdjacentCode = + !Chunks.empty() && Chunks.back().Kind == Chunk::InlineCode; std::string Norm = canonicalizeSpaces(std::move(C

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall updated this revision to Diff 261399. sammccall marked an inline comment as done. sammccall added a comment. tweak coment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79139/new/ https://reviews.llvm.org/D79139 Files: clang-tools-extra

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:439 + bool AdjacentCode = + !Chunks.empty() && Chunks.back().Kind == Chunk::InlineCode; std::string Norm = canonicalizeSpaces(std::move(Code)); I would say we should

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall updated this revision to Diff 261301. sammccall marked an inline comment as done. sammccall added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79139/new/ https://reviews.llvm.org/D79139 Files: clang-tools-

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:419 C.Contents = std::move(Norm); C.Kind = Chunk::InlineCode; return *this; kadircet wrote: > i think we always want a s

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:419 C.Contents = std::move(Norm); C.Kind = Chunk::InlineCode; return *this; i think we always want a space before code chu

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Old model: chunks are always separated by one space. This makes it impossible to render "Foo `bar`.