[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4645ef17ff1a: [clangd] Add CMake dependencies for Protobuf-generated files (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D79085?vs=260906&id=260920#toc Repository: rG LLVM

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. In D79085#2010025 , @sammccall wrote: > Haha, CMake :-( Now that I know this it kind of makes sense (I guess it's faster to just build everything and then link when all deps are ready), just something I didn't think about :)

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev updated this revision to Diff 260906. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Use DEPENDS instead of add_dependencies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79085/new/ https://reviews.llvm.org/D79085 F

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Haha, CMake :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79085/new/ https://reviews.llvm.org/D79085 __

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:22 ) + add_dependencies(clangdRemoteIndex RemoteIndexProtos) is this equivalent to `DEPENDS RemoteIndexProtos` in the library? Slightly clearer probably. R

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. Otherwise sources including `Index.pb.h` or `Index.grpc.pb.h` can be compiled before the those headers are generated. https://github.com/kirillbobyrev/indexing-tools/runs/629305684 (disregard the mess in the repo) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kbobyrev added a comment. Otherwise sources including `Index.pb.h` or `Index.grpc.pb.