This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.
Closed by commit rG97c407db7725: [clangd] Make use of URIs in FileShardedIndex
(authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D79079?vs=261061&id=26114
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/FileIndex.h:59
+/// A container of slabs associated with a key. It can be updated at key
+/// granularity, replacing all
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/Background.cpp:183
const auto &IGN = IndexIt.getValue();
// Note that sources do not contain any information regarding missing
// headers, since we
kadircet updated this revision to Diff 261061.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Update FileSymbols to express keys are not necessarily file paths.
- Use Uri for keys of PreambleSymbols
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
sammccall added a comment.
LG but I think we can skip one lot of conversion, let me know what you think.
Comment at: clang-tools-extra/clangd/index/Background.cpp:183
const auto &IGN = IndexIt.getValue();
// Note that sources do not contain any information regarding m
kadircet updated this revision to Diff 260878.
kadircet added a comment.
- Return None and change PathRef to auto since it is URI now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79079/new/
https://reviews.llvm.org/D79079
Files:
clang-tools-ex
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
This makes FileShardedIndex more robust and gets rid of the need for a
URIToFileCache, as it is done by
