[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). Ah, I've done that (since I primarily build in the shared mod

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Thanks all, yes, it is passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). OK, this now builds for me in shared mode after e7a7deb60ab

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. I think there's more, just running a local shared build so I can catch them (I should really have done this ahead of time). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. Ah, sorry, stale tab :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Herald added a subscriber: wuzish. Looks like this is causing buildbot failure when built with `-DBUILD_SHARED_LIBS=ON`. http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio FAILED: lib/libclangDaemon.so.11git : && /home/b

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

This revision was automatically updated to reflect the committed changes. Closed by commit rGad97ccf6b26a: [clangd] Move non-clang base pieces into separate support/ lib. NFCI (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D790

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall updated this revision to Diff 260905. sammccall added a comment. Update CMakeLists for non-default configurations, optimistically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 Files: clang-to

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 __

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall updated this revision to Diff 260665. sammccall added a comment. Avoid dep on clang header for thread stack size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 Files: clang-tools-extra/clangd/

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. Of the pieces I was unsure about: - I didn't move `Protocol` - it's not a perfect fit, though it may still end up here - I moved `FSProvider` but not `FS` - I didn't move `URI` - I suspect that will *probably* end up wherever `Protocol` does, though it may belong in s

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny. Herald added a project: clang. sammccall added a comment. Of the pieces I was unsure about: - I