[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

2020-05-18 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG968d293063bc: [clang-tidy] NFC: Cleanup Python scripts (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

2020-04-28 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D78985#2007715 , @kbobyrev wrote: > In D78985#2007669 , @Eugene.Zelenko > wrote: > > > It would be great to also run Flake9 and PyLint. > > > Those were actually from pylint. That

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

2020-04-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In D78985#2007669 , @Eugene.Zelenko wrote: > It would be great to also run Flake9 and PyLint. Those were actually from pylint. That's a good idea, but I didn't fix all the warnings there and while I might get back to this in t

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

2020-04-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 260627. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Remove python3 from shebang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm.org/D78985 Files: clan

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

2020-04-28 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. It would be great to also run Flake9 and PyLint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm.org/D78985 ___ cfe-commits mailing list cf

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

2020-04-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks for cleaning up. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:1 -#!/usr/bin/env python +#!/usr/bin/env python3 # we should keep using `p

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

2020-04-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Silence few PEP8 warnings. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78985 Files: clang-tools-extra/clang-tidy/add_new_che