[PATCH] D78902: [Driver] Add output file to properties of Command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70bf35070a74: [Driver] Add output file to properties of Command (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D78902: [Driver] Add output file to properties of Command

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added inline comments. Comment at: clang/include/clang/Driver/Job.h:165 + const llvm::opt::ArgStringList &Arguments, ArrayRef Inputs, + ArrayRef Outputs); // FIXME: This really shouldn't be copyable, but is currently copied in some

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 296625. sepavloff marked an inline comment as done. sepavloff added a comment. Add default argument for parameter Output in constructors of Command* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ ht

[PATCH] D78902: [Driver] Add output file to properties of Command

yaxunl added inline comments. Comment at: clang/include/clang/Driver/Job.h:165 + const llvm::opt::ArgStringList &Arguments, ArrayRef Inputs, + ArrayRef Outputs); // FIXME: This really shouldn't be copyable, but is currently copied in some Is

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:135 + Bundler, BundlerArgs, Inputs, + InputInfo(&JA, Output.c_str(; }

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 296451. sepavloff added a comment. Use MakeArgString to get persistent string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.

[PATCH] D78902: [Driver] Add output file to properties of Command

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:135 + Bundler, BundlerArgs, Inputs, + InputInfo(&JA, Output.c_str(; } I would suggest to use `Args.M

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a reviewer: jyknight. sepavloff added a comment. This change is similar to D82782 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 _

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 291899. sepavloff added a comment. Rebase and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cp

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 289693. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D78902: [Driver] Add output file to properties of Command

MaskRay added a comment. What's the advantage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Adding output files property is a prerequisite for D78903 (Add option -fproc-stat-report). Despite large size of the patch, the change is very simple: it only adds new state variable `OutputFilenames` initialized by the new parameter

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 280796. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 277069. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 271918. sepavloff added a comment. Clang-formatted the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Dri

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 271917. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff created this revision. sepavloff added reviewers: rjmccall, rnk, yaxunl, plotfi, mstorsjo, dlj. Herald added subscribers: kerbowa, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRa