This revision was automatically updated to reflect the committed changes.
Closed by commit rG9ff3f339e881: [clangd] Fix remote index build without shared
libs mode (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78885/new/
http
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:8
)
-target_compile_definitions(clangd-index-server PRIVATE -D
GOOGLE_PROTOBUF_NO_RTTI=1
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:8
)
-target_compile_definitions(clangd-index-server PRIVATE -D
GOOGLE_PROTOBUF_NO_RTTI=1)
-clang_target_link_libraries(clangd-index-server
sammccall wrote:
kbobyrev updated this revision to Diff 260618.
kbobyrev marked 5 inline comments as done.
kbobyrev added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78885/new/
https://reviews.llvm.org/D78885
Files:
clang-to
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:22
+
+DONT_CHECK_FILE_LIST
)
would be nice to avoid specifying this here if it's not needed
Comment at: clang-tools-extra/clangd/index/re
kbobyrev updated this revision to Diff 260606.
kbobyrev added a comment.
Don't create a separate directory for proto files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78885/new/
https://reviews.llvm.org/D78885
Files:
clang-tools-extra/clangd/
kbobyrev updated this revision to Diff 260188.
kbobyrev added a comment.
Slightly adjust the CMake scripts.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78885/new/
https://reviews.llvm.org/D78885
Files:
clang-tools-extra/clangd/index/remote/CMa
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet,
arphaman, jkorous, MaskRay, ilya-biryukov, mgorny.
Herald added projects: clang, LLVM.
Generated Protobuf library has to be in CLANG_EXPORTS and should a
