[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGf89f7da999f3: [IR] Convert null-pointer-is-valid into an enum attribute (authored by nikic). Changed prior to commit: https://reviews.llvm.org/D78862?vs=261375&id=264285#toc Repository: rG LLVM Githu

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added subscribers: jurahul, kuter. In D78862#2027254 , @arsenm wrote: > In D78862#2012560 , @jdoer

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

arsenm added a comment. In D78862#2012560 , @jdoerfert wrote: > I think this is an improvement over the status quo and it looks fine to me. > > @arsenm I agree that we should tie this to the data layout (or at least > should try) but I guess there are ope

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic added a comment. Herald added a subscriber: stephenneuendorffer. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78862/new/ https://reviews.llvm.org/D78862 ___ cfe-commits mailing list cfe-com

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic updated this revision to Diff 261375. nikic added a comment. Fix rebase mistake in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78862/new/ https://reviews.llvm.org/D78862 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/delet

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic updated this revision to Diff 261279. nikic marked an inline comment as done. nikic added a comment. Rebase over committed NFC changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78862/new/ https://reviews.llvm.org/D78862 Files: clang/l

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

jdoerfert added a comment. I think this is an improvement over the status quo and it looks fine to me. @arsenm I agree that we should tie this to the data layout (or at least should try) but I guess there are open questions to answer and code to write. I propose to accept this and work on the DL

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

manojgupta added a comment. @nikic Thanks for the work. In D78862#2003684 , @arsenm wrote: > FWIW I think this attribute should be replaced with a data layout property, > so this would eventually be removed @arsenm Is there any work planned on moving

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic added a comment. @arsenm If the `null-pointer-is-valid` attribute is moved into the data layout, I'm wondering how Clang's `-fno-delete-null-pointer-checks` option would work or what it would be replaced with. In Rust it is possible to define a custom target, which also defines a custom d

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic added a comment. In D78862#2003684 , @arsenm wrote: > FWIW I think this attribute should be replaced with a data layout property, > so this would eventually be removed Is this change planned more for the near term or the long term? I'm not really

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

arsenm added a comment. In D78862#2003684 , @arsenm wrote: > FWIW I think this attribute should be replaced with a data layout property, > so this would eventually be removed Also would be address space specific Repository: rG LLVM Github Monorepo

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

arsenm added a comment. FWIW I think this attribute should be replaced with a data layout property, so this would eventually be removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78862/new/ https://reviews.llvm.org/D78862 ___

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

nikic updated this revision to Diff 260105. nikic added a comment. Herald added subscribers: cfe-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, asbirlea, jfb, george.burgess.iv. Her