[PATCH] D78658: [clang][Frontend] Add missing error handling

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd14a1f6fff3: [clang][Frontend] Add missing error handling (authored by LemonBoy, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. > Looks good to me - thanks! Great! Can you please commit this for me as I have no commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie accepted this revision. dblaikie added a comment. Looks good to me - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 298133. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cpp Index: clang/unittests/Frontend/ASTUnitTest.cpp

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie accepted this revision. dblaikie added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:1158-1160 + if (!Clang->hasTarget()) { return true; + } You can remove these braces now - since it's a superfluous change here now there's no need

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 297959. LemonBoy added a comment. Use `ScopeExit` instead of a bare lambda. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cpp

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie added a comment. In D78658#2327615 , @LemonBoy wrote: >> Perhaps this'd be more robust with ScopeExit? > > Not really, `OnError` is not executed when/if the function succeeds. Ah, sorry - ScopeExit has a 'release()' function intended to disengage

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. > Perhaps this'd be more robust with ScopeExit? Not really, `OnError` is not executed when/if the function succeeds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-c

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie added a comment. Perhaps this'd be more robust with ScopeExit? ( https://llvm.org/doxygen/ScopeExit_8h_source.html ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing l

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping with some more reviewers, hoping to land this in time for LLVM 99. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78658: [clang][Frontend] Add missing error handling

andrewrk accepted this revision. andrewrk added a comment. This revision is now accepted and ready to land. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commit

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 259374. LemonBoy added a comment. Fix a C&P error in the attached test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cp

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy created this revision. LemonBoy added a reviewer: rsmith. LemonBoy added a project: clang. Herald added a subscriber: cfe-commits. Some early errors during the ASTUnit creation were not transferred to the `FailedParseDiagnostic` so when the code in `LoadFromCommandLine` swaps its conten