kmclaughlin added a comment.
Thank you both for your comments on this patch, @efriedma & @sdesmalen!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78569/new/
https://reviews.llvm.org/D78569
___
cfe-com
This revision was automatically updated to reflect the committed changes.
kmclaughlin marked an inline comment as done.
Closed by commit rG53dd72a87aeb: [SVE][CodeGen] Lower SDIV & UDIV to SVE
intrinsics (authored by kmclaughlin).
Changed prior to commit:
https://reviews.llvm.org/D78569?vs=2596
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11388
return LowerSVEIntrinsicEXT(N, DAG);
+case Intrinsic::aarch64_sve_sdiv:
+return DAG.ge
kmclaughlin updated this revision to Diff 259610.
kmclaughlin added a comment.
- Removed changes to handle legalisation from this patch (this will be included
in a follow up)
- Added AArch64ISD nodes for SDIV_PRED & UDIV_PRED
- Changed LowerDIV to use the new ISD nodes rather than lowering to SVE
sdesmalen added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670
+ Mask, Op.getOperand(0), Op.getOperand(1));
+}
+
efriedma wrote:
> sdesmalen wrote:
> > efriedma wrote:
> > > If we're going to support these op
efriedma added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670
+ Mask, Op.getOperand(0), Op.getOperand(1));
+}
+
sdesmalen wrote:
> efriedma wrote:
> > If we're going to support these operations, we might as w
sdesmalen added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670
+ Mask, Op.getOperand(0), Op.getOperand(1));
+}
+
efriedma wrote:
> If we're going to support these operations, we might as well just add isel
>
efriedma added a comment.
I'd prefer to handle legalization in a separate patch from handling legal
sdiv/udiv operations, so we actually have some context to discuss the
legalization strategy.
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670
+
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, c-rhodes, efriedma, cameron.mcinally.
Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
This patch maps IR operations for sdiv &
