This revision was automatically updated to reflect the committed changes.
Closed by commit rGde361df3f6d0: [analyzer][Z3-refutation] Fix a refutation
BugReporterVisitor bug (authored by steakhal).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78457/n
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2871
+ // Overwrite the associated constraint of the Symbol.
+ Constraints = CF.remove(Constraints, Sym);
Constraints = CF.add(Constraints, Sym, C.second);
--
mikhail.ramalho added a comment.
Nice work, @steakhal!
I remember discussing with @NoQ a way of going backward on the bug report, from
the error node, and never add constraints of symbols that were already
collected; that way we would always have the tighter constraints.
I don't quite remember
steakhal added a comment.
I'm planning to measure how impactful this patch is using the CodeChecker.
Stay tuned if you are interested!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78457/new/
https://reviews.llvm.org/D78457
___
cfe-commits
martong accepted this revision.
martong added a comment.
LGTM! Thanks for addressing the comments!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78457/new/
https://reviews.llvm.org/D78457
___
cfe-commits mailing list
cfe-commits@lists.llvm.
steakhal updated this revision to Diff 260108.
steakhal retitled this revision from "[analyzer][Z3-refutation] Fix refutation
BugReporterVisitor bug and refactor" to "[analyzer][Z3-refutation] Fix a
refutation BugReporterVisitor bug".
steakhal edited the summary of this revision.
steakhal added a
