This revision was automatically updated to reflect the committed changes.
Closed by commit rG1a0d46608131: [AST] Preserve the invalid initializer for
auto VarDecl. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D78365?vs=258309&id=260241#toc
Repository:
rG LLVM Githu
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:11852
+ // There are unresolved typos in Init. Usually it indicates the
+ // initializer is very ill-formed, just drop it.
RealDecl->setInvalidDecl();
-
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Oops, intended to accept this (with the comment above)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78365/new/
https://reviews.llvm.org/D
sammccall added a comment.
Nice!
Yet another case of "do we need to stop here" though. Do you have a doc or bug
or somewhere to collect the different directions we could/should extend in?
Comment at: clang/lib/Sema/SemaDecl.cpp:11852
+ // There are unresolved typos in In
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, ilya-biryukov.
Herald added a project: clang.
fixes https://github.com/clangd/clangd/issues/330
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D78365
Files:
clang/
