[PATCH] D78323: [clang] Fix invalid comparator in tablegen

fowles added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78323/new/ https://reviews.llvm.org/D78323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

EricWF closed this revision. EricWF added a comment. af2968e37f4c95846ffe287b64a4fcd72c765bee Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78323/new/ https://reviews.llvm.org/D

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

EricWF added a comment. In D78323#1987596 , @sdesmalen wrote: > LGTM, did this comparison introduce any non-determinism? Potentially, but I observed the issue using libc++'s debug mode. I'm unsure if the current inputs would have caused libc++ to read pa

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, did this comparison introduce any non-determinism? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78323/new/ https://reviews.llvm.org

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

EricWF created this revision. EricWF added reviewers: fowles, bkramer, sdesmalen. Herald added a project: clang. The current version of the comparator does not introduce a strict weak ordering. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78323 Files: clang/utils/TableGen/