PiotrZSL added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/performance-for-range-copy.cpp:66-67
}
+ for (const S S2 : C) {
+ }
}
Those tests already exist and pass in current version.
Most probably this change is obsolete.
Rep
PiotrZSL added a comment.
Release notes are missing, and patch not not apply gracefully.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78223/new/
https://reviews.llvm.org/D78223
___
cfe-commits mailing li
xgupta added a comment.
Herald added subscribers: PiotrZSL, carlosgalvezp.
Herald added a project: All.
Reverse ping, this patch was never gets committed after being accepted.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78223/new/
https://reviews.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from some small nits
Comment at: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp:68
+// loop index because it's less clear than copying the temporary.
+static bool isCopyConstructedFr
EricWF created this revision.
EricWF added reviewers: fowles, shuaiwang.
EricWF added a project: clang-tools-extra.
Herald added subscribers: mgehre, xazax.hun.
Currently the range-for-copy incorrectly suggests changing a
by-value loop var to a reference to avoid copies even when:
(1) A co
