[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

This revision was automatically updated to reflect the committed changes. Closed by commit rGceba881aeac1: [AVR][NFC] Move preprocessor tests to Preprocessor directory (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ ht

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163 __

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

aykevl updated this revision to Diff 259621. aykevl added a comment. - moved test files out of the AVR-specific directory - removed the `REQUIRES:` line In D78163#1984210 , @rjmccall wrote: > I don't think the REQUIRES is needed unless there's something s

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

rjmccall added a comment. I don't think the REQUIRES is needed unless there's something special about AVR as a target. Clang doesn't conditionally compile out frontend target support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

aykevl added a comment. Honestly I don't know the convention but I agree with @rjmccall that the convention appears to be to not use a separate subdirectory (I don't see any other arch-specific subdirectories). So, should the files be moved to clang/test/Preprocessor/avr-*.c (e.g. clang/test/Pr

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

rjmccall added a comment. Looks like the established convention would be to just put these tests in `test/Preprocessor` with an `avr-` prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

MaskRay added a comment. Not sure we need `target-cpu-defines/` You can add a `lit.local.cfg` to avoid `REQUIRES: avr-registered-target` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163 __

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

aykevl created this revision. aykevl added reviewers: dylanmckay, rjmccall, MaskRay. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. MaskRay added a comment. Not sure we need `target-cpu-defines/` You can add a `lit.local.cfg` to avoid `REQUIRES: avr-registered-target`