aykevl added a comment.
Okay, I have committed this patch and created a new patch to move the files:
https://reviews.llvm.org/D78163
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78117/new/
https://reviews.llvm.org/D78117
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe06e231ff15: [AVR] Define __ELF__ (authored by aykevl).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78117/new/
https://reviews.llvm.org/D78117
Files:
c
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I agree that these tests are in the wrong directory; please prepare a patch
that moves them. This patch is okay to go, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
MaskRay added a comment.
The `test/clang/Preprocessor/` directory may make more sense for such tests. Is
it time to create a target-specific sub directory
`test/clang/Preprocessor/AVR/`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78117/new/
ht
aykevl updated this revision to Diff 257358.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78117/new/
https://reviews.llvm.org/D78117
Files:
clang/lib/Basic/Targets/AVR.cpp
clang/test/CodeGen/avr/target-cpu-defines/atmega328p.c
clang/test/Code
aykevl created this revision.
aykevl added reviewers: dylanmckay, rjmccall, MaskRay.
aykevl added a project: LLVM.
Herald added subscribers: cfe-commits, Jim.
Herald added a project: clang.
aykevl updated this revision to Diff 257358.
This symbol is defined in avr-gcc. Because AVR normally uses th