[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm closed this revision. arsenm added a comment. 3a612450508b314b7a6f4db142d0c619031d760e CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 __

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 ___ cfe-commits mailing list cfe-

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm updated this revision to Diff 257676. arsenm added a comment. Fix comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/cl-denorms-are-zero.cl clang/test/Driver/cuda-

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

yaxunl added inline comments. Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:26 +// Test no subtarget +// FIXME: This defaults to gfx803, but gets a different denormal mode than explicitly specifying it. +// RUN: %clang -x hip -no-canonical-prefixes -### -target x

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm updated this revision to Diff 257318. arsenm added a comment. Fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/cl-denorms-are-zero.cl clang/test/Driver/cuda-flu

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm added a comment. In D78020#1978034 , @yaxunl wrote: > I think https://reviews.llvm.org/D78019 should fix the issue about HIP not > using correct default denormal value if no arch is specified. > > In that case, driver actually sets offloading arch

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm added a comment. In D78020#1978034 , @yaxunl wrote: > I think https://reviews.llvm.org/D78019 should fix the issue about HIP not > using correct default denormal value if no arch is specified. > > In that case, driver actually sets offloading arch

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

yaxunl added a comment. I think https://reviews.llvm.org/D78019 should fix the issue about HIP not using correct default denormal value if no arch is specified. In that case, driver actually sets offloading arch to gfx803 and clang should be able to see it in JobAction. CHANGES SINCE LAST ACT

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner, msearles. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. arsenm added a parent revision: D78019: HIP: Fix handling of denormal mode. Since the default logic was based on