[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm closed this revision. arsenm added a comment. dc89a3efb43feedec04facfa2206de011d2606e7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 __

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm added a comment. In D78019#1978216 , @tra wrote: > LGTM. The patch appears to be an NFC one for CUDA. CUDA currently isn't changing the default FTZ mode based on the subtarget, which differs from nvcc according to the documentation CHANGES SINC

[PATCH] D78019: HIP: Fix handling of denormal mode

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 ___ cfe-commits mailing list cfe-

[PATCH] D78019: HIP: Fix handling of denormal mode

tra added a comment. LGTM. The patch appears to be an NFC one for CUDA. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm updated this revision to Diff 257011. arsenm added a comment. Remove leftover comment from before I used JobAction CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChai

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:27 +// Test multiple offload archs with different defaults. +// RUN: %clang -x hip -no-canonical-prefixes -### -target x86_64-linux-gnu -c -march=

[PATCH] D78019: HIP: Fix handling of denormal mode

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:286 + +// FIXME: Should this use the default mode based on the target? How do we +// deal with multiple --cuda-gpu-arch? If there are multiple --cuda-gpu-arch, driver will cr

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm created this revision. arsenm added reviewers: yaxunl, tra. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. arsenm added a child revision: D78020: clang/AMDGPU: Assume denormals are enabled for the default target.. I didn't realize HIP was a distinct offloading kind, so the sub