sylvestre.ledru reopened this revision.
sylvestre.ledru added a comment.
has been reverted
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77983/new/
https://reviews.llvm.org/D77983
___
cfe-commits maili
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc0f79ea5b99: clang-tidy doc: add a note for checkers with
an autofix (authored by sylvestre.ledru).
Repository:
rG LLV
sylvestre.ledru added a comment.
@alexfh ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77983/new/
https://reviews.llvm.org/D77983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
sylvestre.ledru added a comment.
@alexfh ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77983/new/
https://reviews.llvm.org/D77983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
sylvestre.ledru updated this revision to Diff 257105.
sylvestre.ledru added a comment.
Doing it by hand. @alexfh please let me know if you would be ok with it
(I will do it by hand)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77983/new/
https://r
sylvestre.ledru added a comment.
Makes sense.
I will give it a try :)
thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77983/new/
https://reviews.llvm.org/D77983
___
cfe-commits mailing list
cfe-co
alexfh added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/abseil-duration-conversion-cast.rst:29-35
Note: In the second example, the suggested fix could yield a different result,
as the conversion to integer could truncate. In practice, this is very r
sylvestre.ledru updated this revision to Diff 256943.
sylvestre.ledru added a comment.
2 spaces instead of 4
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77983/new/
https://reviews.llvm.org/D77983
Files:
clang-tools-extra/docs/clang-tidy/checks
Eugene.Zelenko added a comment.
Herald added a subscriber: wuzish.
It'll be reasonable to use two spaces indent. At least this is what mostly used
for code blocks. Options are exceptions, but will be good idea to reformat them
eventually.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
sylvestre.ledru created this revision.
sylvestre.ledru added reviewers: alexfh, aaron.ballman.
Herald added subscribers: Charusso, arphaman, kbarton, nemanjai.
Herald added a project: clang.
Currently, when looking at a checker documentation, we have to go back
to the whole list or look at the sou
10 matches
Mail list logo