[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-05-02 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. In D77910#2015225 , @arsenm wrote: > In D77910#1989163 , @b-sumner wrote: > > > In D77910#1988807 , @arsenm wrote: > > > > > In D77910#1981828

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-05-01 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D77910#1989163 , @b-sumner wrote: > In D77910#1988807 , @arsenm wrote: > > > In D77910#1981828 , @b-sumner > > wrote: > > > > > In D77910#1981429

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-17 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. In D77910#1988807 , @arsenm wrote: > In D77910#1981828 , @b-sumner wrote: > > > In D77910#1981429 , @arsenm wrote: > > > > > In D77910#1976171

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-17 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D77910#1981828 , @b-sumner wrote: > In D77910#1981429 , @arsenm wrote: > > > In D77910#1976171 , @b-sumner > > wrote: > > > > > I don't think we c

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-14 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. In D77910#1981429 , @arsenm wrote: > In D77910#1976171 , @b-sumner wrote: > > > I don't think we can guarantee this is or will be supported on all devices. > > The language runtime makes

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-14 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 257470. arsenm added a comment. Check triple OS CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77910/new/ https://reviews.llvm.org/D77910 Files: clang/lib/Basic/Targets/AMDGPU.h clang/test/Misc/amdgcn.languageOptsOpenCL.cl Index: clang/test/Mis

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-14 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D77910#1976171 , @b-sumner wrote: > I don't think we can guarantee this is or will be supported on all devices. > The language runtime makes this decision. We don't need to worry about theoretical devices. We should know the

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-11 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. I don't think we can guarantee this is or will be supported on all devices. The language runtime makes this decision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77910/new/ https://reviews.llvm.org/D77910 ___ c

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I am not so sure whether compiler should always report this. I thought it depends on platform and should let runtime to add it when it is really supported. But on the other hand, we could report it by default if it is the most case, and let runtime to disable it if it i

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

2020-04-10 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia. Herald added subscribers: danielkiss, kerbowa, kristof.beyls, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. This doesn't seem to be that useful, since it doesn't change any device side functions. Report it since