This revision was automatically updated to reflect the committed changes.
Closed by commit rGeeff1a970a6b: [analyzer][CallAndMessage][NFC] Split up
checkPreCall (authored by Szelethus).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77846/new/
https:
balazske accepted this revision.
balazske added a comment.
This revision is now accepted and ready to land.
Looks good. Not sure if it work in all cases after the `MallocChecker` problems
but we can fix problems if any later.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77846/new/
htt
Szelethus updated this revision to Diff 265214.
Szelethus marked 4 inline comments as done.
Szelethus added a comment.
Fixes according to @balazske's comments, cheers!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77846/new/
https://reviews.llvm.org/D77846
Files:
clang/lib/StaticAnal
Szelethus added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:27
#include "llvm/Support/Casting.h"
+#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/raw_ostream.h"
balazske wrote:
> Are these new includes
balazske added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:27
#include "llvm/Support/Casting.h"
+#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/raw_ostream.h"
Are these new includes needed?
Reposito
balazske added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:481
+ ProgramStateRef State = C.getState();
+ if (isa(Call) || isa(Call)) {
+
The one thing where I am not sure is if this condition is really needed for
ev
Szelethus created this revision.
Szelethus added reviewers: NoQ, xazax.hun, balazske, martong,
baloghadamsoftware, rnkovacs, dcoughlin.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso,
gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sid
