[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd abandoned this revision. compnerd added a comment. Given that the original motivation here was to help with NetBSD, and the submodule visibility flag handling unblocks NetBSD, I think that I will hold off on this unless some other motivation arises. Repository: rG LLVM Github Monore

[PATCH] D77697: libc++: adjust modulemap for non-modular C

ldionne accepted this revision as: libc++. ldionne added a comment. LGTM since other reviewers are fine with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77697/new/ https://reviews.llvm.org/D77697 ___

[PATCH] D77697: libc++: adjust modulemap for non-modular C

rsmith added a comment. In D77697#1968998 , @joerg wrote: > This fixes the module build of clang for me. Are you building with or without `-fmodules-local-submodule-visibility` (`cmake -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=ON`)? If you don't use that

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd added a comment. I think that a `clang-pcm` like tool would be **incredible**. Working with modules is somewhat frustrating because there is no good supported way to see what the module structure that clang actually sees. But that goes well beyond an attempt to repair the NetBSD buil

[PATCH] D77697: libc++: adjust modulemap for non-modular C

Bigcheese added a comment. In D77697#1970586 , @dexonsmith wrote: > In D77697#1969998 , @compnerd wrote: > > > @dexonsmith - yeah, sadly I dont think that there is a good way to audit > > that - any change to the p

[PATCH] D77697: libc++: adjust modulemap for non-modular C

dexonsmith added a subscriber: Bigcheese. dexonsmith added a comment. In D77697#1969998 , @compnerd wrote: > @dexonsmith - yeah, sadly I dont think that there is a good way to audit that > - any change to the public headers can cause issues. Furthermore,

[PATCH] D77697: libc++: adjust modulemap for non-modular C

joerg added a comment. @ldionne I was updating libc++ from d42baff45d9700a199982ba0ac04dbc6c6d911bb and LLVM itself from 38aebe5c04ab4cb3695dc1bcc60b9a7b55215aff

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd added a comment. @dexonsmith - yeah, sadly I dont think that there is a good way to audit that - any change to the public headers can cause issues. Furthermore, the libc headers themselves also influence this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D77697: libc++: adjust modulemap for non-modular C

ldionne added a comment. In D77697#1968998 , @joerg wrote: > This fixes the module build of clang for me. @joerg When did it start failing for you? And what part of it did? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D77697: libc++: adjust modulemap for non-modular C

joerg added a comment. This fixes the module build of clang for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77697/new/ https://reviews.llvm.org/D77697 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D77697: libc++: adjust modulemap for non-modular C

dexonsmith added a comment. This SGTM in principle, but the patch makes me wonder: which other headers from the non-modularized C runtime change ownership? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77697/new/ https://reviews.llvm.org/D77697

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd created this revision. compnerd added a reviewer: ldionne. Herald added subscribers: libcxx-commits, dexonsmith. Herald added a project: libc++. Herald added a reviewer: libc++. When building with a non-modularized C runtime, `csignal` would claim `time.h` and thus `timespec` rather than