[PATCH] D77598: Integral template argument suffix printing

rsmith added a comment. In D77598#1990197 , @rsmith wrote: > Is is feasible to check whether the corresponding template parameter either > has a deduced type or is a parameter of a function template? If not, we don't > need to clarify the type of the tem

[PATCH] D77598: Integral template argument suffix printing

reikdas updated this revision to Diff 261774. reikdas added a comment. Sorry my earlier update did not include the changes from the earlier revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp clang

[PATCH] D77598: Integral template argument suffix printing

reikdas updated this revision to Diff 261772. reikdas added a comment. Addresses @rsmith 's inline comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp cla

[PATCH] D77598: Integral template argument suffix printing

reikdas added a comment. I updated the diff here - https://reviews.llvm.org/D79290. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D77598: Integral template argument suffix printing

rsmith added a comment. Is is feasible to check whether the corresponding template parameter either has a deduced type or is a parameter of a function template? If not, we don't need to clarify the type of the template argument and could leave off the suffix to shorten the printed argument.

[PATCH] D77598: Integral template argument suffix printing

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template.cpp:34 -// CHECK: ![[TC]] = distinct !DICompositeType(tag: DW_TAG_structure_type, name: "TC" +// CHECK: ![[TC]] = distinct !DICompositeType(tag: DW_TAG_structure_type, name: "T

[PATCH] D77598: Integral template argument suffix printing

arisKoutsou updated this revision to Diff 255810. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp clang/test/CXX/lex/lex.literal/lex.ext/p12.cpp clang/test/Cod

[PATCH] D77598: Integral template argument suffix printing

arisKoutsou updated this revision to Diff 255755. arisKoutsou added a comment. Herald added a subscriber: arphaman. Updated some tests to reflect the change in integral template argument printing(U and LL suffix). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D77598: Integral template argument suffix printing

hubert.reinterpretcast added a comment. Is this actually appropriate for an argument to `template ` or should the type be reflected in more than the suffix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598

[PATCH] D77598: Integral template argument suffix printing

arisKoutsou created this revision. arisKoutsou added a reviewer: v.g.vassilev. arisKoutsou added a project: clang. Herald added a subscriber: cfe-commits. Added 'U' suffix for unsigned integral types and 'LL' for 64-bit types. Some tests fail to pass due to this change, because they expect a diag