[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2021-04-06 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added inline comments. Herald added a reviewer: bollu. Herald added a subscriber: sstefan1. Herald added a project: clang-tools-extra. Comment at: clang/lib/ASTMatchers/CMakeLists.txt:17-18 ) + +target_link_libraries(clangASTMatchers PUBLIC LLVMFrontendOpenMP) ---

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-07 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. Thanks. Not sure if there's a buildbot that uses `-DLLVM_LINK_LLVM_DYLIB=ON -DLLVM_BUILD_LLVM_DYLIB=ON`, but I think you can build with it yourself to reproduce it. About how to resolve the issue, I have no idea, sorry. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D77574#1967141 , @aheejin wrote: > Could you revert this patch? This is causing an error like this whenever I > run `clang` binary: > > : CommandLine Error: Option 'openmp-ir-builder-optimistic-attributes' > registered mor

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-07 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. Could you revert this patch? This is causing an error like this whenever I run `clang` binary: : CommandLine Error: Option 'openmp-ir-builder-optimistic-attributes' registered more than once! LLVM ERROR: inconsistency in registered CommandLine options This happens

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-07 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @lebedev.ri @jdoerfert Looks like it might have caused: https://bugs.llvm.org/show_bug.cgi?id=45453 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://reviews.llvm.org/D77574 ___

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-06 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG97aa593a8387: [OpenMP] Fix layering problem with FrontendOpenMP (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://re

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-06 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://reviews.llvm.org/D77574 _

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

2020-04-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added a reviewer: lebedev.ri. Herald added subscribers: martong, guansong, bollu, yaxunl, mgorny. Herald added a project: clang. lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG ASTMatche