[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff abandoned this revision. sepavloff added a comment. FPOptions is now stored in AST objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77545/new/ https://reviews.llvm.org/D77545 ___ cfe-comm

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. In D77545#1977688 , @sepavloff wrote: > In D77545#1974509 , @rjmccall wrote: > > > For example, in this code: > > > > const float global = 2.22 + 3.33; > > > > #pragma STDV FENV_ROUND

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff added a comment. In D77545#1974509 , @rjmccall wrote: > For example, in this code: > > const float global = 2.22 + 3.33; > > #pragma STDV FENV_ROUND > float getGlobal() { return global; } > > > The code-generation of `getGlobal` will att

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. > ! In D77545#1973765 , @sepavloff > wrote: > >> ! In D77545#1973169 , @rjmccall >> wrote: >> all of which will just do the wrong thing if they don't preserve and pass >> down the right

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff added a comment. In D77545#1973169 , @rjmccall wrote: > Pragma nodes don't require AST changes to existing nodes, but they require > large changes to a number of clients, If a client is unaware of peculiarities of floating point operations, it

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. In D77545#1972344 , @sepavloff wrote: > The solution in D76384 (Move FPFeatures > from BinaryOperator bitfields to Trailing storage) causes several concerns. > > 1. It requires substantial code c

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff added a comment. The solution in D76384 (Move FPFeatures from BinaryOperator bitfields to Trailing storage) causes several concerns. 1. It requires substantial code changes. The patch in D76384 is already large and we

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. The goal here seems to be to avoid the need to store pragma state in operator expressions. As I mentioned in another review, I'm not sure how directly interesting that goal is if we can avoid memory overhead in the common case. Storing pragma state in operators certa

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, andrew.w.kaylor, efriedma, mibintc, kpn, sammccall, hokein. Herald added a subscriber: martong. Herald added a project: clang. The patch D76599 proposed a new statement node to represe