[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

nathanchance added a comment. > These are new tests how do you get the generic lld driver to work? It doesn't, Clang invokes the appropriate driver in `ToolChain::GetLinkerPath()`: https://github.com/llvm/llvm-project/blob/6011627f5118dd64a0c33694b604c70e766d8c40/clang/lib/Driver/ToolChain.cpp#

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

bcain added a comment. In D77498#1968123 , @sidneym wrote: > Since this isn't something that can be always known in advance I think the > testcase should just be removed. Why not just check if `CLANG_DEFAULT_LINKER` is empty? const char *getDefaultLi

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym added a comment. Since this isn't something that can be always known in advance I think the testcase should just be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77498/new/ https://reviews.llvm.org/D77498 __

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym added a comment. These are new tests how do you get the generic lld driver to work? When I invoke it using just "lld" I need to add -flavor gnu or I get this error: Invoke ld.lld (Unix), ld64.lld (macOS), lld-link (Windows), wasm-ld (WebAssembly) instead Repository: rG LLVM Github M

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

nathanchance added a comment. > Weird -- the baseline didn't take CLANG_DEFAULT_LINKER into account either, > though, right? I assume by baseline you mean the test before this change? It does not seem like it. > Is it a regression? I guess not but the test is still broken when `CLANG_DEFAULT_

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

bcain added a comment. In D77498#1967870 , @nathanchance wrote: > This does not take into account `CLANG_DEFAULT_LINKER`, resulting in a > `check-clang` failure: Weird -- the baseline didn't take CLANG_DEFAULT_LINKER into account either, though, right

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

nathanchance added a comment. This does not take into account `CLANG_DEFAULT_LINKER`, resulting in a `check-clang` failure: $ cmake -GNinja \ -DCMAKE_C_COMPILER=clang \ -DCMAKE_CXX_COMPILER=clang++ \ -DLLVM_ENABLE_PROJECTS=clang \

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c5d6dfda98e: [Hexagon] Make lld be the default linker for linux/musl (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77498/new/ https:

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym created this revision. sidneym added reviewers: adasgupt, bcain, kparzysz, bcahoon, shankare. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the target is hexagon-unknown-linux-musl select lld as the default linker. Repository: rG LLVM Github Monorepo http