[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

rjmccall requested changes to this revision. rjmccall added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaDecl.cpp:3759 unsigned BuiltinID; - if (Old->isImplicit() && (BuiltinID = Old->getBuiltinID())) { + bool RevertedBuiltin

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

hokein added a subscriber: rjmccall. hokein added a comment. sorry for the long delay, unfortunately I'm not familiar enough with the code to do a good review. +cc @rjmccall may have more context (from the git log), could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a reviewer: MaskRay. tambre added a comment. Could someone please review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mail

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a comment. rsmith: ping 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre added a comment. rsmith: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

yutsumi accepted this revision. yutsumi added a comment. This revision is now accepted and ready to land. Thank you very much. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

yutsumi added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre created this revision. tambre added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We didn't mark them previously as non-builtin in non-global scope if we determined they were incompatible redeclarations. This caused problems down the line with t