[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG937e63b8d5e9: [X86] Fix x86-header-warnings.c test not detecting regressions as intended. (authored by Pierre Gousseau ). Changed prior to commit: https://reviews.llvm.org/D77

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau added a comment. In D77393#1969419 , @probinson wrote: > It looks like you're not actually interested in the compiled output, but just > whether warnings occurred; in that case you'd be better off with `-verify > -fsyntax-only` and `// expected

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

probinson added a comment. It looks like you're not actually interested in the compiled output, but just whether warnings occurred; in that case you'd be better off with `-verify -fsyntax-only` and `// expected-no-diagnostics`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau reopened this revision. pgousseau added a comment. This revision is now accepted and ready to land. Reopening to fix false negative test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 255666. pgousseau added a comment. Fix false negative test introduce while attempting to add label check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning: + _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON); RKSimon wrote: > Add a LABEL check

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

thakis added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:3 +// in intrinsic headers. +// Preprocess file to workaround no warnings in system headers. +// RUN: %clang_cc1 %s -triple x86_64-pc-linux-gnu -ffreestanding -E 2>&1 \ Does Wsyste

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG08fab9ebecf7: [X86] Fix implicit sign conversion warnings in X86 headers. (authored by Pierre Gousseau ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 255626. pgousseau added a comment. Added label CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/Headers/xmmintrin.h clang/test/Headers/x86-header-warning

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with the minor addition an extra CHECK-LABEL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

craig.topper added a comment. Seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon added a comment. @craig.topper Any comments? Hopefully we can add extra tests as time goes on (for instance I'm intending to add Wdocumentation test coverage for PR35949). Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning:

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 254827. pgousseau added a comment. Renaming test and including x86intrin.h instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/Headers/xmmintrin.h

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon added a reviewer: RKSimon. RKSimon added a comment. Rename test file to x86-header-warnings.c or something similarly specific? Comment at: clang/test/Headers/warn-cleanup.c:10 +#include +#include + Use x8intrin.h directly so its easier to expand in th

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau created this revision. pgousseau added reviewers: craig.topper, probinson, filcab. Herald added a project: clang. Herald added a subscriber: cfe-commits. Warnings in emmintrin.h and xmmintrin.h are reported by -fsanitize=implicit-integer-sign-change Repository: rG LLVM Github Monore