[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d1c6529b95: [SanitizerCoverage] sancov/inline-bool-flag instrumentation. (authored by pratyai, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D77244?vs=256182&id=256190#to

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 256182. pratyai added a comment. Adjusted the diff in the change (`align 1` is dropped from the llvm instruction of the CHECK). The reason is that it does not get set until setAlignment is explicitly called (ref: https://llvm.org/doxygen/Instructions_8cpp_s

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 256175. pratyai added a comment. oops; forgot that dropping the `alignment == 1 ? 1 : alignment / 8` bit off this diff wouldn't work with build. (running a --check-llvm, but it's a bit slow; if things break I'll update again) Repository: rG LLVM Github M

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 256167. pratyai marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: llvm/include/llvm/Transforms/Instrumentation.h llvm/lib/Trans

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai added a comment. In D77244#1970820 , @vitalybuka wrote: > In D77244#1956930 , @pratyai wrote: > > > It looks like I broke the tests after the `i8 `-> `i1` switch. > > > > I think it's because of an existing

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:922 +auto Store = IRB.CreateStore(ConstantInt::getTrue(Int1Ty), FlagPtr); +Store->setAtomic(AtomicOrdering::NotAtomic); +Store->setAlignment(llvm::MaybeAlign(Functi

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added a comment. In D77244#1956930 , @pratyai wrote: > It looks like I broke the tests after the `i8 `-> `i1` switch. > > I think it's because of an existing bug. From > https://llvm.org/docs/LangRef.html > > > i1:8:8 - i1 is 8-bit (byte) align

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added a comment. In D77244#1956805 , @pratyai wrote: > Undid the `arc lint` on autocomplete.c. > `arc lint` does not seem to have an option --style, but it's just one line > diff anyway. yep. it had --style LLVM by mistake. I guess it's fixe

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 255619. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: llvm/include/llvm/Transforms/Instrumentation.h llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cp

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 254919. pratyai retitled this revision from "sancov/inline-bool-flag feature + tests + docs." to "[part 1] sancov/inline-bool-flag instrumentation.". pratyai added a comment. Herald added a project: LLVM. Dropped files from outside llvm/.../Instrumentation* a