[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert abandoned this revision. jdoerfert added a comment. In D77240#1957468 , @tra wrote: > In D77240#1957386 , @jdoerfert wrote: > > > I just noticed those as well. I forgot to put the new definitions into the

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. In D77240#1957386 , @jdoerfert wrote: > I just noticed those as well. I forgot to put the new definitions into the > forward declare header. Will do it in a second. The OpenMP math overlay > doesn't have one so I forgot :( I'm not

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert added a comment. I just noticed those as well. I forgot to put the new definitions into the forward declare header. Will do it in a second. The OpenMP math overlay doesn't have one so I forgot :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. We do have a problem. With your patch I see a lot of errors about function redefinitions conflicting with the ones in CUDA's `math_functions.hpp`: E.g: In file included from :1: In file included from /usr/local/google/home/tra/work/llvm/build/release+assert+zapcc/lib/c

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert added a comment. In D77240#1955755 , @tra wrote: > In D77240#1955724 , @jdoerfert wrote: > > > At least that one is defined in what is "now" `__clang_cuda_math.h`: > > > Cool. We may be OK, but we still ne

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. In D77240#1955724 , @jdoerfert wrote: > At least that one is defined in what is "now" `__clang_cuda_math.h`: Cool. We may be OK, but we still need to verify it. Math headers are rather fragile and we need to make sure it all still w

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert added a comment. In D77240#1955678 , @tra wrote: > We'll need to make sure that all of these new functions are vailable in all > supported CUDA versions. > E.g. `acoshf` does not seem to be present in CUDA-9. At least that one is defined in w

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. We'll need to make sure that all of these new functions are vailable in all supported CUDA versions. E.g. `acoshf` does not seem to be present in CUDA-9. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77240/new/ https://reviews

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert created this revision. jdoerfert added a reviewer: tra. Herald added subscribers: bollu, yaxunl. Herald added a project: clang. Some function overloads for floats were missing, found by running a test suite [0] with the OpenMP overlay. [0] https://github.com/TApplencourt/OmpVal Depends