[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

2020-04-05 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. > Tested in VSCode insiders (with a patched client to enable experimental > features). In case it's useful to others: the required change to the client to opt into this appears to be calling `registerProposedFeatures()` on the `LanguageClient` object. Repository: rG

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

2020-04-02 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3063eaceec: [clangd] Support textDocument/semanticTokens/edits (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77225?vs=254226&id=254536#toc Repository: rG LLVM Github M

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

2020-04-02 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. this is neat, and the new semantic highlighting protocol is much nicer than the old one. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1245 +static void increment

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

2020-04-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This returns incremental highlights as a set of edits against the previous highlights.