[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bf055c9891f: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer (authored by hlopko, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D77209?vs=255654&id=255

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255654. hlopko added a comment. Assert the Spelled subrange more effectively Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, &Spelled.front()); + unsigned SpelledFrontI = &Spelled.front() - File.SpelledTokens.data(); + unsigned ExpandedBegin; gr

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255610. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling/Syntax/To

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255609. hlopko marked 6 inline comments as done. hlopko added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, &Spelled.front()); + unsigned SpelledFrontI = &Spelled.front() - File.SpelledTokens.data(); + unsigned ExpandedBegin; ---

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko marked an inline comment as done. hlopko added a comment. Adressing comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, &Spelled.front()); + unsigned SpelledFrontI = &Spelled.front() - File.SpelledToke

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255326. hlopko marked 4 inline comments as done. hlopko added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:239 + + auto It = llvm::partition_point(F.Mappings, [SpelledI](const Mapping &M) { +return M.BeginSpelled <= SpelledI; It would be great to add an is_sorted assertion to the bu

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 254188. hlopko added a comment. Adding comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same restrictions apply as in the other direction: macro arguments are not supported yet, only full macro expansions can be mapped. Taking over from https://reviews.llvm.org/D72581. Repository: