[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7314aea5a42d: [clang] Move branch-protection from CodeGenOptions to LangOptions (authored by danielkiss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7713

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77131/new/ https://reviews.llvm.org/D77131 ___ cfe-commits mailing list cfe-commi

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz updated this revision to Diff 254174. tamas.petz added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77131/new/ https://reviews.llvm.org/D77131 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOption

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

chill added a reviewer: efriedma. chill added a subscriber: efriedma. chill added a comment. Following @efriedma comment here http://lists.llvm.org/pipermail/cfe-dev/2020-March/065017.html LGTM. Comment at: clang/include/clang/Basic/TargetInfo.h:18 #include "clang/Basic/Addr

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz added a comment. Tests pass, however, I am not sure ParseLangArgs is called in all the necessary cases (see the occurrences in the code). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77131/new/ https://reviews.llvm.org/D77131 __

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

danielkiss added a comment. just a nit, LGTM otherwise. Comment at: clang/include/clang/Basic/CodeGenOptions.def:402 #undef VALUE_CODEGENOPT - is this change necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz marked an inline comment as done. tamas.petz added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:402 #undef VALUE_CODEGENOPT - danielkiss wrote: > is this change necessary? I think there should be one new line at the end o

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz created this revision. tamas.petz added a reviewer: momchil.velikov. tamas.petz added a project: clang. Herald added a subscriber: cfe-commits. danielkiss added a comment. tamas.petz marked an inline comment as done. just a nit, LGTM otherwise. Comment at: clang/incl