yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Sema/Sema.cpp:1558
+// visited before.
+if (Done.count(FD))
+ return;
rjmccall wrote:
> yaxunl wrote:
> > rjmccall wrote:
> > > `insert` returns whether it c
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rG2c31aa2de13a: Speed up deferred diagnostic emitter (authored
by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
rjmccall added inline comments.
Comment at: clang/lib/Sema/Sema.cpp:1558
+// visited before.
+if (Done.count(FD))
+ return;
yaxunl wrote:
> rjmccall wrote:
> > `insert` returns whether it changed the set, so you can combine this check
> > with the i
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Sema/Sema.cpp:1558
+// visited before.
+if (Done.count(FD))
+ return;
rjmccall wrote:
> `insert` returns whether it changed the set, so you can combine this
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thank you. Minor request, but feel free to commit with that change.
Comment at: clang/lib/Sema/Sema.cpp:1558
+// visited before.
+if (Done.count(FD))
+ retu
yaxunl updated this revision to Diff 255315.
yaxunl marked an inline comment as done.
yaxunl retitled this revision from "[NFC] Refactor DeferredDiagsEmitter and
skip redundant visit" to "Speed up deferred diagnostic emitter".
yaxunl edited the summary of this revision.
yaxunl added a comment.
Re
