This revision was automatically updated to reflect the committed changes.
Closed by commit rG7ea64ae3afe4: [analyzer] Use IgnoreImpCasts() instead of
reimplementing it. (authored by thakis).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
Charusso accepted this revision.
Charusso marked an inline comment as done.
Charusso added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512
+ return E->IgnoreImpCasts();
}
--
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512
+ return E->IgnoreImpCasts();
}
NoQ wrote:
> Charusso wrote:
> > I think it would make sense to remove the helper-f
NoQ added a comment.
Fair!
Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512
+ return E->IgnoreImpCasts();
}
Charusso wrote:
> I think it would make sense to remove the helper-function completely. (Being
> used 2 times.)
Yup.
CHANG
Charusso added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512
+ return E->IgnoreImpCasts();
}
I think it would make sense to remove the helper-function completely. (Being
used 2 times.)
CHANGES SINCE LAST ACTION
