[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-30 Thread Vince Bridgers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdefd95ef4517: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHA

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-30 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. Oh, yea, LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77012/new/ https://reviews.llvm.org/D77012 ___ cfe-commits mailing list

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-30 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D77012#1948550 , @NoQ wrote: > @Szelethus can we make this checker depend on undefined value checker > (probably CallAndMessage) so that uninitialized arguments were handled first? I'll drop some pointers to previous disc

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-30 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. LGTM and thanks! In D77012#1948550 , @NoQ wrote: > Thanks! > > @Szelethus can we make this checker depend on undefined value checker > (probably CallAndMessage) so that uninitialized arguments were

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-29 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 253434. vabridgers added a comment. fix pre-merge lint checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77012/new/ https://reviews.llvm.org/D77012 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFu

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a reviewer: Szelethus. NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! @Szelethus can we make this checker depend on undefined value checker (probably CallAndMessage) so that uninitialized arguments were handled first? In fact,

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-29 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 253419. vabridgers added a comment. fix pre-merge lint checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77012/new/ https://reviews.llvm.org/D77012 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFu

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

2020-03-29 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers created this revision. vabridgers added reviewers: martong, NoQ. Herald added subscribers: ASDenysPetrov, Charusso, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Herald added a project: clang. This check was causing a crash in a test case where the 0th