This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe3033c0ce551: [llvm][clang][IFS] Enhancing the llvm-ifs yaml
format for symbol lists. (authored by plotfi).
Repository:
plotfi updated this revision to Diff 254080.
plotfi added a comment.
Trying to fix precommit / clang tidy checks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76979/new/
https://reviews.llvm.org/D76979
Files:
clang/include/clang/Frontend/Fronte
plotfi updated this revision to Diff 254075.
plotfi added a comment.
Updating to change im about to land, to see what precommit changes show.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76979/new/
https://reviews.llvm.org/D76979
Files:
clang/i
plotfi updated this revision to Diff 253367.
plotfi added a comment.
fixing linter errors
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76979/new/
https://reviews.llvm.org/D76979
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clang/lib/Front
plotfi updated this revision to Diff 253369.
plotfi added a comment.
Adding a better test to check the deprecated v1 format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76979/new/
https://reviews.llvm.org/D76979
Files:
clang/lib/Frontend/Compi
compnerd added a comment.
Please address the linter warnings. I think that adding an additional test to
demonstrate that the `experimental-ifs-version-v1` is properly diagnosed is a
good idea. LGTM other than that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://re
plotfi updated this revision to Diff 253360.
plotfi added a comment.
Changing some of the version checks. I don't think we need to have rigid checks
considering this format is experimental.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76979/new/
plotfi updated this revision to Diff 253314.
plotfi added a comment.
Herald added a subscriber: wuzish.
-U999
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76979/new/
https://reviews.llvm.org/D76979
Files:
clang/lib/Frontend/CompilerInvocation.c
plotfi created this revision.
plotfi added a reviewer: compnerd.
Herald added subscribers: cfe-commits, kbarton, nemanjai.
Herald added a project: clang.
plotfi updated this revision to Diff 253314.
plotfi added a comment.
Herald added a subscriber: wuzish.
-U999
These file format changes have b
