[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

2020-03-30 Thread Florian Hahn via Phabricator via cfe-commits
fhahn marked an inline comment as done. fhahn added a comment. Thanks for taking a look @dexonsmith! In D76916#1947324 , @dexonsmith wrote: > @fhahn, please revert, this isn't how we usually pass options in LTO. Reverted in 7899a111ea1160e2ae0aae42de37b

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

2020-03-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a subscriber: Florian. dexonsmith added a comment. @fhahn, please revert, this isn't how we usually pass options in LTO. If this is something we expect developers to use, it should be specifiable on a per-TU basis. The way we do this is by specifying it during compilation, att

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

2020-03-27 Thread Florian Hahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9ce198d6ed37: [Darwin] Respect -fno-unroll-loops during LTO. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76916/new/ https://reviews.l

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

2020-03-27 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76916/new/ https://reviews.llvm.org/D76916 __

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

2020-03-27 Thread Florian Hahn via Phabricator via cfe-commits
fhahn created this revision. fhahn added reviewers: thegameg, steven_wu. Herald added subscribers: cfe-commits, dang, dexonsmith, zzheng, hiraditya, inglorion. Herald added a project: clang. Currently -fno-unroll-loops is ignored when doing LTO on Darwin. This patch adds a new -lto-no-unroll-loop